From 1c084937c08e41ad02dc81653630dfa5f34b8547 Mon Sep 17 00:00:00 2001 From: tatsy <tatsy.mail@gmail.com> Date: Thu, 19 Feb 2015 17:49:53 +0900 Subject: [PATCH] Add unit tests for improve the coverage. --- Makefile | 1 + bower.json | 2 +- lib/imsize/index.js | 2 +- package.json | 1 + test/test.js | 20 ++++++++++++++++++-- 5 files changed, 22 insertions(+), 4 deletions(-) diff --git a/Makefile b/Makefile index 1326846..7451fbd 100644 --- a/Makefile +++ b/Makefile @@ -8,6 +8,7 @@ lint: publish: webpack ./ uglifyjs dist/markdown-it-imsize.js > dist/markdown-it-imsize.min.js + bower register markdown-it-imsize https://github.com/tatsy/markdown-it-imsize.git test: lint mocha diff --git a/bower.json b/bower.json index 0a8bfc7..a9eff32 100644 --- a/bower.json +++ b/bower.json @@ -18,6 +18,6 @@ "test", "helpers", "Makefile", - "index*" + "lib" ] } diff --git a/lib/imsize/index.js b/lib/imsize/index.js index 836b97e..03788db 100644 --- a/lib/imsize/index.js +++ b/lib/imsize/index.js @@ -28,7 +28,7 @@ function lookup(buffer, filepath) { } function asyncFileToBuffer(filepath, callback) { - fs.oepn(filepath, 'r', function(err0, descriptor) { + fs.open(filepath, 'r', function(err0, descriptor) { if (err0) { return callback(err0); } diff --git a/package.json b/package.json index 0c40058..953505a 100644 --- a/package.json +++ b/package.json @@ -29,6 +29,7 @@ "markdown-it": "^3.0.4", "markdown-it-testgen": "^0.1.4", "mocha": "^2.1.0", + "should": "^5.0.0", "uglify-js": "^2.4.16", "webpack": "^1.5.3" } diff --git a/test/test.js b/test/test.js index 753eccc..ca4c1a1 100644 --- a/test/test.js +++ b/test/test.js @@ -3,6 +3,7 @@ var assert = require('assert'); var path = require('path'); var generate = require('markdown-it-testgen'); +var should = require('should'); describe('markdown-it-imsize', function() { var md = require('markdown-it')({ @@ -23,9 +24,10 @@ describe('markdown-it-imsize (autofill)', function() { }); describe('image size detector', function() { + var imsize = require('../lib/imsize'); + var types = require('../lib/imsize/types'); + it('image size detector', function(done) { - var imsize = require('../lib/imsize'); - var types = require('../lib/imsize/types'); types.forEach(function(type) { var dim = imsize('./test/img/lena.' + type); assert.equal(dim.width, 128); @@ -33,4 +35,18 @@ describe('image size detector', function() { }); done(); }); + + it('imsize detector anync', function() { + types.forEach(function(type) { + imsize('./test/img/lena.' + type, function(err, dim) { + assert.equal(dim.width, 128); + assert.equal(dim.height, 128); + }); + }); + }); + + it('invalid operation', function(done) { + (function() { imsize('./test/img/lena.svg') }).should.throw(); + done(); + }); }); -- GitLab