Reforma vyhodnocování práv

Vyhodnocování práv bylo dost nešikovné, na spoustě míst bylo potřeba kešovat. Předěláno.

Viz issue #31 (closed).

mo/web/org_contest.py

@@ -16,7 +16,6 @@ from mo.csv import FileFormat
 import mo.db as db
 from mo.imports import ImportType, create_import
 import mo.jobs.submit
-import mo.rights
 from mo.rights import Right, Rights
 import mo.util
 from mo.util_format import inflect_number
@@ -78,11 +77,9 @@ class ParticipantsActionForm(FlaskForm):
 
     remove_participation = wtforms.SubmitField("Smazat záznam o účasti")
 
-    def do_action(self, round: db.Round, rights: Rights, query: Query) -> bool:
+    def do_action(self, round: db.Round, query: Query) -> bool:
         """Do participation modification on partipations from given query
-        (possibly filtered by checkboxes). `rights` param is used to check rights
-        for contest of each modified participation or for contest in which
-        participation is moved to."""
+        (possibly filtered by checkboxes)."""
 
         if not self.validate_on_submit():
             return False
@@ -106,8 +103,8 @@ class ParticipantsActionForm(FlaskForm):
             if not contest:
                 flash(f"Nepovedlo se najít soutěž v kole {round.round_code()} v oblasti {contest_place.name}", 'danger')
                 return False
-            rights.get_for_contest(contest)
-            if not rights.have_right(Right.manage_contest):
+            rr = g.gatekeeper.rights_for_contest(contest)
+            if not rr.have_right(Right.manage_contest):
                 flash(f"Nemáte právo ke správě soutěže v kole {round.round_code()} v oblasti {contest_place.name}, nelze do ní přesunout účastníky", 'danger')
                 return False
         elif self.remove_participation.data:
@@ -124,17 +121,12 @@ class ParticipantsActionForm(FlaskForm):
 
         # Check all participations if we can edit them
         ctants = query.all()
-        rights_cache = set()
         for pion, _, _ in ctants:
             u = pion.user
             if self.action_on.data == 'checked' and u.user_id not in user_ids:
                 continue
-            if pion.contest_id in rights_cache:
-                continue
-            rights.get_for_contest(pion.contest)
-            if rights.have_right(Right.manage_contest):
-                rights_cache.add(pion.contest_id)
-                continue
+            rr = g.gatekeeper.rights_for_contest(pion.contest)
+            if not rr.have_right(Right.manage_contest):
                 flash(
                     f"Nemáte právo ke správě soutěže v kole {round.round_code()} v oblasti {pion.contest.place.name} "
                     + f"(účastník {u.full_name()}). Žádná akce nebyla provedena.", 'danger'
@@ -189,7 +181,7 @@ class ParticipantsActionForm(FlaskForm):
 
 
 class DownloadButtonForm(FlaskForm):
-    download = wtforms.SubmitField('Stáhnout všechna řešení jako ZIP')
+    download = wtforms.SubmitField('Stáhnout řešení jako ZIP')
     download_feedback = wtforms.SubmitField('Stáhnout opravená jako ZIP')
 
 
@@ -206,8 +198,7 @@ def get_contest(id: int) -> db.Contest:
 def get_contest_rr(id: int, right_needed: Optional[Right] = None) -> Tuple[db.Contest, Rights]:
     contest = get_contest(id)
 
-    rr = Rights(g.user)
-    rr.get_for_contest(contest)
+    rr = g.gatekeeper.rights_for_contest(contest)
 
     if not (right_needed is None or rr.have_right(right_needed)):
         raise werkzeug.exceptions.Forbidden()
@@ -215,7 +206,7 @@ def get_contest_rr(id: int, right_needed: Optional[Right] = None) -> Tuple[db.Co
     return contest, rr
 
 
-def get_contest_site_rr(id: int, site_id: Optional[int], right_needed: Optional[Right] = None) -> Tuple[db.Contest, db.Place, Rights]:
+def get_contest_site_rr(id: int, site_id: Optional[int], right_needed: Optional[Right] = None) -> Tuple[db.Contest, Optional[db.Place], Rights]:
     if site_id is None:
         contest, rr = get_contest_rr(id, right_needed)
         return contest, None, rr
@@ -225,8 +216,7 @@ def get_contest_site_rr(id: int, site_id: Optional[int], right_needed: Optional[
     if not site:
         raise werkzeug.exceptions.NotFound()
 
-    rr = Rights(g.user)
-    rr.get_for_contest_site(contest, site)
+    rr = g.gatekeeper.rights_for_contest_site(contest, site)
 
     if not (right_needed is None or rr.have_right(right_needed)):
         raise werkzeug.exceptions.Forbidden()
@@ -274,7 +264,7 @@ def org_contest(id: int, site_id: Optional[int] = None):
         'org_contest.html',
         contest=contest, site=site,
         db=db,  # kvůli hodnotám enumů
-        rights=sorted(rr.current_rights, key=lambda r: r. name),
+        rights=sorted(rr.rights, key=lambda r: r. name),
         can_manage=rr.have_right(Right.manage_contest),
         can_edit_points=rr.have_right(Right.edit_points) and contest.round.state == db.RoundState.grading,
         tasks=tasks, places_counts=places_counts,
@@ -355,7 +345,7 @@ def org_contest_list(id: int, site_id: Optional[int] = None):
     action_form = None
     if can_edit:
         action_form = ParticipantsActionForm()
-        if action_form.do_action(round=contest.round, rights=rr, query=query):
+        if action_form.do_action(round=contest.round, query=query):
             # Action happened, redirect
             return redirect(request.url)
 
@@ -518,8 +508,7 @@ def get_solution_context(contest_id: int, user_id: Optional[int], task_id: Optio
             if not site:
                 raise werkzeug.exceptions.NotFound()
 
-    rr = Rights(g.user)
-    rr.get_for_contest_site(contest, site or contest.place)
+    rr = g.gatekeeper.rights_for_contest_site(contest, site or contest.place)
 
     # Kdo má právo na jaké operace
     allow_upload_solutions = (rr.have_right(Right.upload_submits)
@@ -872,3 +861,33 @@ def org_contest_solutions(id: int, site_id: Optional[int] = None):
         db=db,  # kvůli hodnotám enumů
         download_form=download_form,
     )
+
+
+class UploadFeedbackForm(FlaskForm):
+    file = flask_wtf.file.FileField("Soubor")
+    submit = wtforms.SubmitField('Odeslat')
+
+
+@app.route('/org/contest/c/<int:id>/upload-feedback', methods=('GET', 'POST'))
+def org_upload_feedback(id: int):
+    sc = get_solution_context(id, None, None, None)
+    if not sc.allow_upload_feedback:
+        raise werkzeug.exceptions.Forbidden()
+
+    form = UploadFeedbackForm()
+
+    if form.validate_on_submit():
+        # FIXME: Viz komentář o efektivitě v user_contest_task
+        tmp_name = secrets.token_hex(16)
+        tmp_path = os.path.join(app.instance_path, 'tmp', tmp_name)
+        form.file.data.save(tmp_path)
+
+        mo.jobs.submit.schedule_upload_feedback(sc.round, tmp_path, f'Nahrání opravených řešení {sc.round.round_code()}', g.user)
+        return redirect(url_for('org_jobs'))
+
+    return render_template(
+        'org_upload_feedback.html',
+        round=sc.round,
+        contest=sc.contest,
+        form=form,
+    )